fix: address final-review findings before closing Plan 1
- privilege: wire sudo -v to real stdin/stdout/stderr so it can prompt - cmd: validate --only/--skip IDs against registry (prevents silent run-all on typo); gate install to Arch-only (spec requirement); mark --only and --skip mutually exclusive - platform: Pacman.Update now runs -Syu --noconfirm, not -Sy (avoids Arch partial-upgrade anti-pattern) - test/integration: trap-clean the named docker volume on any exit - go.mod: tidy — yaml.v3 is a direct dep
This commit is contained in:
@@ -80,7 +80,7 @@ func TestPacmanUpdate(t *testing.T) {
|
||||
if err := p.Update(context.Background()); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
want := []string{"sudo", "pacman", "-Sy"}
|
||||
want := []string{"sudo", "pacman", "-Syu", "--noconfirm"}
|
||||
if !reflect.DeepEqual(r.runCalls[0], want) {
|
||||
t.Fatalf("args = %v, want %v", r.runCalls[0], want)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user